Fix typing errors with set_extenion methods #13613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg:
```
Argument of type "(span: Span, tag: str) -> str" cannot be assigned to parameter "method" of type "SpanMethod | None" in function "set_extension"
Type "(span: Span, tag: str) -> str" is incompatible with type "SpanMethod | None"
"function" is incompatible with protocol "SpanMethod"
"__call__" is not present
"function" is incompatible with "None"PylancereportArgumentType
```
Rationale:
`Callable` only accepts a single parameter, optional parameters don't work
... isn't recognized as variadic arguments (... not valid here)
SomeMethod(Protocol) __call__ approach doesn't support mapping non variadic arguments to variadic arguments.
Therefore, to not break the currently documented interface, implement a union of Callable overloads.
|
The current way does indeed look broken, but if we can't make it correct I'd rather just declare them as |
|
Hey @honnibal,
I agree, I just didn't want to break the current API. Turns out the docs in master use PR updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eg:
Rationale:
Callableonly accepts a single parameter, optional parameters don't work...isn't recognized as variadic arguments (...not valid here)SomeMethod(Protocol) __call__approach doesn't support mapping non variadic arguments to variadic arguments.Therefore, to not break the currently documented interface, implement a union of Callable overloads.
Types of change
Typing fix
Checklist